Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small QOL improvements #11

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Small QOL improvements #11

wants to merge 9 commits into from

Conversation

mariuskoeppen
Copy link

This will add some quality-of-life improvements:

  • Add default Trunk.toml file from the trunk repo with some basic settings preconfigured.
  • Get prompted what channel (stable/nightly) to use and configure the files accordingly.
  • Get prompted if default VS Code editor settings should be added. This mainly configures the rustfmt command. In future we could add support for other text editors.
  • Change default from CSS to SCSS. In my opinion there are no downsides to SCSS over CSS.

@gbj
Copy link
Contributor

gbj commented Nov 6, 2024

This looks good to me overall! My one question has to do with the VS Code settings: if the user does not have leptosfmt installed, how does rust-analyzer handle this?

@mariuskoeppen
Copy link
Author

mariuskoeppen commented Nov 7, 2024 •
edited
Loading

When you don't have leptosfmt installed you will get the following error on saving:

[Error - 8:20:34 AM] Request textDocument/formatting failed.
  Message: Failed to spawn cd "[project_path]/src/components" && "leptosfmt" "--stdin" "--rustfmt"
  Code: -32603

Only formatting will not work, otherwise everything is fine. We could mention in the Readme that leptosfmt should be installed manually.

@gbj
Copy link
Contributor

gbj commented Nov 14, 2024

Okay, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariuskoeppen @gbj